Skip to content

🎨 Tint leading list icons in dark mode#17243

Open
AndyScherzinger wants to merge 1 commit into
masterfrom
claude/activity-notification-icons-7wk3py
Open

🎨 Tint leading list icons in dark mode#17243
AndyScherzinger wants to merge 1 commit into
masterfrom
claude/activity-notification-icons-7wk3py

Conversation

@AndyScherzinger

@AndyScherzinger AndyScherzinger commented Jun 23, 2026

Copy link
Copy Markdown
Member

SVG activity/notification icons decode into a PictureDrawable, which ignores tint, so the leading icons stayed dark-on-dark in dark mode. Now rasterized into a tintable BitmapDrawable and themed via viewThemeUtils, so the tint applies in both themes.

AI disclosure: assisted by ClaudeCode (claude-opus-4-8).

@AndyScherzinger AndyScherzinger force-pushed the claude/activity-notification-icons-7wk3py branch from 9e5d82a to 20565fb Compare June 23, 2026 21:52
@AndyScherzinger AndyScherzinger marked this pull request as draft June 23, 2026 21:53
@AndyScherzinger AndyScherzinger force-pushed the claude/activity-notification-icons-7wk3py branch 8 times, most recently from fcc6e79 to 7b99ed0 Compare June 23, 2026 22:20
@AndyScherzinger AndyScherzinger force-pushed the claude/activity-notification-icons-7wk3py branch 2 times, most recently from f87e9c7 to bc02aa5 Compare June 24, 2026 18:41
Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the claude/activity-notification-icons-7wk3py branch from 42af22c to 5c16fee Compare June 24, 2026 20:29
@github-actions

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3131
Correctness6767
Dodgy code211211
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness2929
Performance4141
Security1616
Total405405

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/28127572033/artifacts/7861727286
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@AndyScherzinger AndyScherzinger marked this pull request as ready for review June 24, 2026 20:53
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 24, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 24, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 24, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 24, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 24, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 24, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 24, 2026
@AndyScherzinger AndyScherzinger changed the title fix(activity,notifications): tint leading list icons in dark mode 🎨 Tint leading list icons in dark mode Jun 24, 2026

@nickvergessen nickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍 and code looks reasonable 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants