🎨 Tint leading list icons in dark mode#17243
Open
AndyScherzinger wants to merge 1 commit into
Open
Conversation
9e5d82a to
20565fb
Compare
fcc6e79 to
7b99ed0
Compare
f87e9c7 to
bc02aa5
Compare
Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
42af22c to
5c16fee
Compare
|
APK file: https://github.com/nextcloud/android/actions/runs/28127572033/artifacts/7861727286 |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
nickvergessen
approved these changes
Jun 25, 2026
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Works 👍 and code looks reasonable 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SVG activity/notification icons decode into a
PictureDrawable, which ignores tint, so the leading icons stayed dark-on-dark in dark mode. Now rasterized into a tintableBitmapDrawableand themed viaviewThemeUtils, so the tint applies in both themes.AI disclosure: assisted by ClaudeCode (claude-opus-4-8).